fix: add buffer-length check in sm_at_client.c#339
Open
orbisai0security wants to merge 2 commits into
Open
Conversation
Automated security fix generated by OrbisAI Security
The AT client response processing uses memcpy to copy incoming UART data into the at_cmd_resp buffer without verifying that the destination has sufficient capacity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
lib/sm_at_client/sm_at_client.c.Vulnerability
V-002lib/sm_at_client/sm_at_client.c:285Description: The AT client response processing uses memcpy to copy incoming UART data into the at_cmd_resp buffer without verifying that the destination has sufficient capacity. At line 285, data is copied at offset resp_len without checking that resp_len + copy_len does not exceed the buffer allocation. At line 313, remaining data is similarly copied without bounds validation. A compromised modem or malicious UART data can trigger heap buffer overflow.
Evidence
Exploitation scenario: An attacker with access to the UART interface sends crafted AT responses where the total data length exceeds the at_cmd_resp buffer size.
Scanner confirmation: multi_agent_ai rule
V-002flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
lib/sm_at_client/sm_at_client.cVerification
Security Invariant
Regression test
This test guards against regressions — it's useful independent of the code change above.
Automated security fix by OrbisAI Security